From b9c198ae7434d2872332a71ff6213a581e9cce4e Mon Sep 17 00:00:00 2001 From: Geordan Neukum Date: Fri, 22 Jul 2022 08:00:18 -0400 Subject: [PATCH 1/2] dropdown-header: convert to glimmer Let's update the DropdownHeader component to extend glimmer/component instead of ember/component. Glimmer components offer a bunch of various advantages over classic components and are the direction that ember is heading in general. --- app/components/search-input/dropdown-header.hbs | 10 ++++++++++ app/components/search-input/dropdown-header.js | 5 ----- .../components/search-input/dropdown-header.hbs | 8 -------- 3 files changed, 10 insertions(+), 13 deletions(-) create mode 100644 app/components/search-input/dropdown-header.hbs delete mode 100644 app/components/search-input/dropdown-header.js delete mode 100644 app/templates/components/search-input/dropdown-header.hbs diff --git a/app/components/search-input/dropdown-header.hbs b/app/components/search-input/dropdown-header.hbs new file mode 100644 index 000000000..e10aec219 --- /dev/null +++ b/app/components/search-input/dropdown-header.hbs @@ -0,0 +1,10 @@ +
+
+
+ + {{yield}} + +
+
+
+
\ No newline at end of file diff --git a/app/components/search-input/dropdown-header.js b/app/components/search-input/dropdown-header.js deleted file mode 100644 index 9879c9ac1..000000000 --- a/app/components/search-input/dropdown-header.js +++ /dev/null @@ -1,5 +0,0 @@ -import { classNames } from '@ember-decorators/component'; -import Component from '@ember/component'; - -@classNames('ds-suggestion') -export default class DropdownHeader extends Component {} diff --git a/app/templates/components/search-input/dropdown-header.hbs b/app/templates/components/search-input/dropdown-header.hbs deleted file mode 100644 index f1c44d651..000000000 --- a/app/templates/components/search-input/dropdown-header.hbs +++ /dev/null @@ -1,8 +0,0 @@ -
-
- - {{yield}} - -
-
-
\ No newline at end of file From 816342d3bdabfc5d4cae156f57884624c421573e Mon Sep 17 00:00:00 2001 From: Geordan Neukum Date: Fri, 22 Jul 2022 08:01:23 -0400 Subject: [PATCH 2/2] dropdown-header: prefer single quotes Let's prefer to use single quotes throughout the dropdown-header template file as Prettier will attempt this conversion upon save anyway based on the current configuration. --- app/components/search-input/dropdown-header.hbs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/components/search-input/dropdown-header.hbs b/app/components/search-input/dropdown-header.hbs index e10aec219..057816aaa 100644 --- a/app/components/search-input/dropdown-header.hbs +++ b/app/components/search-input/dropdown-header.hbs @@ -1,10 +1,10 @@ -
-
-
- +
+
+
+ {{yield}}
-
+
\ No newline at end of file