Skip to content

Commit 6c7633e

Browse files
authored
fix: Remove ember-responsive (#1676)
- The package insists on having @ember/string v3 - It does not do too much
1 parent d772ef9 commit 6c7633e

File tree

4 files changed

+54
-190
lines changed

4 files changed

+54
-190
lines changed

addon/components/docs-viewer/x-nav/index.hbs

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,26 @@
1-
{{#if this.media.isMobile}}
2-
<div class="docs-text-right docs-px-4 md:docs-px-6 docs-mt-4">
3-
<button {{on "click" (toggle "isShowingMenu" this)}}
4-
class="docs-text-grey-darkest docs-py-2 docs-text-xs docs-rounded docs-uppercase docs-font-medium">
5-
☰ Menu
6-
</button>
7-
</div>
8-
{{/if}}
1+
<div class="docs-block md:docs-hidden docs-text-right docs-px-4 md:docs-px-6 docs-mt-4">
2+
<button {{on "click" (toggle "isShowingMenu" this)}}
3+
class="docs-text-grey-darkest docs-py-2 docs-text-xs docs-rounded docs-uppercase docs-font-medium">
4+
☰ Menu
5+
</button>
6+
</div>
97

108
<div class="AddonDocs-DocsViewer-Nav docs-bg-grey-lightest docs-border-r docs-flex-no-shrink" ...attributes>
119
<nav {{on "click" (set this "isShowingMenu" false)}}
1210
class="
1311
docs-absolute docs-right-0 docs-shadow-lg md:docs-shadow-none docs-mr-2 md:docs-mr-0 md:docs-pl-2
1412
docs-max-w-xs docs-w-90% md:docs-w-72 docs-z-10 docs-transition md:docs-sticky md:docs-top-0
15-
{{if this.media.isMobile
16-
(if this.isShowingMenu "docs-opacity-100 docs-bg-white" "docs-opacity-0 docs-pointer-events-none")
17-
}}
13+
{{if this.isShowingMenu "docs-opacity-100 docs-bg-white md:docs-opacity-0" "docs-opacity-0 md:docs-opacity-100 docs-pointer-events-none md:docs-pointer-events-auto"}}
1814
">
1915
<div class="docs-pt-px docs-mb-8 docs-px-3 md:docs-px-4 md:docs-max-h-screen md:docs-overflow-y-scroll">
20-
{{#if this.media.isMobile}}
21-
<div class="absolute top-0 docs-text-right right-4">
22-
<button
23-
class="docs-text-grey-darkest docs-opacity-50 hover:docs-opacity-100 docs-text-large-5 docs-py-2 docs-no-underline"
24-
{{on "click" (set this "isShowingMenu" false)}}
25-
>
26-
&times;
27-
</button>
28-
</div>
29-
{{/if}}
16+
<div class="docs-block md:docs-hidden absolute top-0 docs-text-right right-4">
17+
<button
18+
class="docs-text-grey-darkest docs-opacity-50 hover:docs-opacity-100 docs-text-large-5 docs-py-2 docs-no-underline"
19+
{{on "click" (set this "isShowingMenu" false)}}
20+
>
21+
&times;
22+
</button>
23+
</div>
3024

3125
<DocsViewer::XNavList>
3226
{{yield (hash

addon/components/docs-viewer/x-nav/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ export default class XNav extends Component {
1313
root;
1414

1515
@service store;
16-
@service media;
1716

1817
@tracked isShowingMenu;
1918

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@
6161
"ember-concurrency": "^3.1.1",
6262
"ember-keyboard": "^9.0.1",
6363
"ember-modal-dialog": "^4.1.4",
64-
"ember-responsive": "^5.0.0",
6564
"ember-router-generator": "^2.0.0",
6665
"ember-router-scroll": "^4.1.2",
6766
"ember-set-helper": "^2.0.1",

0 commit comments

Comments
 (0)