Skip to content

Commit 98b585a

Browse files
Refactor to make a comparison check verbose
1 parent c624820 commit 98b585a

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

lib/fix-borked-yuidoc-files.js

+6-11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import fs from 'fs-extra'
2-
import semverUtils from 'semver-utils'
2+
import semverCompare from 'semver-compare'
33
import { normalizeYuiDocClassItem } from './yuidoc-fixer/normalize-yui-doc-class-item'
44
import { yuiDocClassItemKeys } from './yuidoc-fixer/yui-doc-class-item-keys'
55
import { normalizeYuiDocClass } from './yuidoc-fixer/normalize-yui-doc-class'
@@ -18,17 +18,12 @@ export default async function fixBorkedYuidocFiles(file) {
1818
return
1919
}
2020

21-
const version = semverUtils.parse(
22-
file
23-
.replace('tmp/s3-docs/v', '')
24-
.replace('/ember-docs.json', '')
25-
.replace('/ember-data-docs.json', '')
26-
)
21+
const version = file
22+
.replace('tmp/s3-docs/v', '')
23+
.replace('/ember-docs.json', '')
24+
.replace('/ember-data-docs.json', '')
2725

28-
if (
29-
parseInt(version['major']) < 3 ||
30-
!(parseInt(version['major']) === 3 && parseInt(version['minor']) >= 10)
31-
) {
26+
if (semverCompare(version, '3.10.0') === -1) {
3227
return file
3328
}
3429

0 commit comments

Comments
 (0)