Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge back to ericmj/mongodb? #7

Open
johnnyshields opened this issue May 2, 2017 · 4 comments
Open

Merge back to ericmj/mongodb? #7

johnnyshields opened this issue May 2, 2017 · 4 comments

Comments

@johnnyshields
Copy link
Contributor

Hi emerleite, just wondering what's preventing merging these changes back into ericmj/mongodb? MongoDB support in Elixir is fairly sparse and would be great if efforts could be pooled into one repo.

@gregory
Copy link

gregory commented Sep 17, 2017

@johnnyshields it appear this is unmaintained.

@emerleite
Copy link
Owner

Hi @gregory and @johnnyshields. This fork was to allow replica sets. I did a pull request for ericmj/mongodb but he didn't accept. He asked me to setup a test with replicas on travisci, which I do not know how to do.

As I need to put my application into production, I'm using this fork but I guess the best is to use ericmj version, not mine.

Best,

Emerson

@johnnyshields
Copy link
Contributor Author

johnnyshields commented Dec 4, 2017

@emerleite the original repo (now https://github.com/ankhers/mongodb) supports replica sets. I've raised PR #8 to add a deprecation notice to the readme for this project to avoid user confusion.

@emerleite
Copy link
Owner

@johnnyshields cool. The last time I did a try, It was Eric's repo and was not working as expected, with reconnections, primary to secondary changes, backoffs, etc.

I'll deprecate it in favor to the original one.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants