Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why nothing in the doc mention data-vaul-drawer-wrapper ? #500

Open
sshmaxime opened this issue Oct 31, 2024 · 1 comment
Open

Why nothing in the doc mention data-vaul-drawer-wrapper ? #500

sshmaxime opened this issue Oct 31, 2024 · 1 comment

Comments

@sshmaxime
Copy link

Maybe I missed it but I cannot see anything in the doc mentioning the need of the data-vaul-drawer-wrapper wrapper, why is that ?

Additionally, would it be possible to get rid of it altogether and just have it working out of the box with only the option shouldScaleBackground set to true ?
@SimonVillage
Copy link

It took me a while to understand what makes the background scale on the main page of vaul. This should be documented, shadcn is using it by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonVillage @sshmaxime