Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/[username]/latest is no longer returning visit count #127

Open
gelicia opened this issue Dec 14, 2014 · 1 comment
Open

User/[username]/latest is no longer returning visit count #127

gelicia opened this issue Dec 14, 2014 · 1 comment

Comments

@gelicia
Copy link

gelicia commented Dec 14, 2014

See http://tributary.io/api/user/gelicia/latest/100/0
The last time it returned a visit count is May 28th.

Good news is, recording visits still works http://tributary.io/api/latest/visits

It's just not aggregating them for the user API call anymore. I'll try to look into this but maybe someone can beat me to it :)

This affects the user page and, consequently, my self esteem (just kidding)

@enjalot
Copy link
Owner

enjalot commented Dec 15, 2014

If you want to look into it, I know the cause of the problem but I don't know the complete solution.

When I aggregate view counts I ignore all gist ids that look like the long hash (instead of the numbers) to avoid returning stats on private gists. recently github changed all the ids to look like the hashes, so its no longer a good way to separate them. What should really happen is that there should be a "private" property on the visits of private gists and we should skip them in the aggregation.

would love it if you dug in, let me know if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants