Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Typescript Support? #6

Open
cozumel424 opened this issue Aug 6, 2021 · 7 comments
Open

Typescript Support? #6

cozumel424 opened this issue Aug 6, 2021 · 7 comments

Comments

@cozumel424
Copy link

It doesn't play nice with typescript which is a shame because this seems like the best emoji picker out there.
yeah

@Nincha
Copy link

Nincha commented Aug 6, 2021

I was just about to report the same exact thing. 😄

TS7016: Could not find a declaration file for module 'vue3-discordpicker'. '/node_modules/vue3-discordpicker/dist/discordpicker.common.js' implicitly has an 'any' type.

Can't wait to see it work with it! Cheers anyway for the outstanding work!

@enzostvs
Copy link
Owner

enzostvs commented Aug 7, 2021

Hi,
For now you can juste create a file discordpicker.d.ts in your project with this
declare module 'vue3-discordpicker';

Soon i rewrite all this component w/typescript and composition-api 👍 (really soon)

Tell me if solution work

@Nincha
Copy link

Nincha commented Aug 11, 2021

Hey!

Thanks for the feedback ; it now compiles the module but the TS errors/warning are still here so this is blocking compilation for the project (built on Quasar). :-)

Off topic, I also noticed a few CSS conflicts between Quasar and Tailwind - which is packing your CSS ; are you interested by a detailed report on this, and how they could potentially be solved ? If i'm not mistaken, the subject has been discussed on Quasar's Github, but as I recall they closed the issue stating that they don't plan to make any changes on their side.

@enzostvs
Copy link
Owner

Hello @Nincha ,
Can you resend me the typescript warning please ?

For the CSS error, if you can explain me what kind of error exactly?
Because normally I generate a tailwind style but linked to a class (.vue3-emojipicker), so the style will be valid only when the parent has this class

@Nincha
Copy link

Nincha commented Aug 12, 2021

Here they are :)

First, error when declaring DiscordPicker in components:
image

Second, wargning about API Key
image

I'm sending you an email with the CSS details :)

@Nincha
Copy link

Nincha commented Aug 14, 2021

@enzostvs seems like the email indicated on your website does not work. :( 😄

@enzostvs
Copy link
Owner

Hi @Nincha yes sorry !
You can send here: [email protected]
Thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants