Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options #6246

Closed
rrodionov91 opened this issue Jan 9, 2025 · 1 comment · Fixed by #6311
Closed

Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options #6246

rrodionov91 opened this issue Jan 9, 2025 · 1 comment · Fixed by #6311
Assignees
@rrodionov91
Labels
Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 3.1.0-rc.1

Comments

@rrodionov91
Copy link
Collaborator

Background
Currently there is an option to import indigo with separated wasm file. However it requires additional configuration on server side to pick up wasm file into build directory.
Indigo already have built with EXPORT_ES6 & USE_ES6_IMPORT_META options turned on during the compilation. It allows to import wasm files using native esm imports.

Solution
Include indigo 1.28.0-dev.3 into ketcher and make it work.
@rrodionov91 rrodionov91 added this to the Ketcher 3.1.0-rc.1 milestone Jan 9, 2025
@rrodionov91 rrodionov91 self-assigned this Jan 13, 2025
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label Jan 15, 2025
@AlexeyGirin
Copy link
Collaborator

No test cases needed for that issue

rrodionov91 added a commit that referenced this issue Jan 17, 2025
@rrodionov91
#6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options
d6740d0 
- added import of indigo with separate wasm using esm imports to automatically take wasm files during the build
@rrodionov91 rrodionov91 linked a pull request Jan 17, 2025 that will close this issue
#6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options #6311
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 20, 2025
@rrodionov91
#6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options (#…
2861c08 
…6311)

- added import of indigo with separate wasm using esm imports to automatically take wasm files during the build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 3.1.0-rc.1
Development

Successfully merging a pull request may close this issue.

#6246 - Import indigo with EXPORT_ES6 & USE_ES6_IMPORT_META options epam/ketcher
2 participants
@rrodionov91 @AlexeyGirin