Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autotests: Replace ZoomIn/ZoomOut/ZoomReset operations with valid helper functions (part 2) #6268

Closed
AlexeyGirin opened this issue Jan 14, 2025 · 0 comments · Fixed by #6285 or #6307
Closed

Autotests: Replace ZoomIn/ZoomOut/ZoomReset operations with valid helper functions (part 2) #6268

AlexeyGirin opened this issue Jan 14, 2025 · 0 comments · Fixed by #6285 or #6307
Assignees
@YatsekTest
Labels
Autotests refactor Code refactoring, without changing the functionality
Milestone
Autotests

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jan 14, 2025 •
edited
Loading

Identify all ZoomIn/ZoomOut/ZoomReset operations made by by using methods
await page.getByTestId('zoom-in').click();,
await page.getByTestId('zoom-default').click()
await page.getByTestId('zoom-out').click()
await page.getByTestId('zoom-selector').click()
and await page.getByTestId('reset-zoom-button').click()

and replace them with proper helper function
function selectZoomInTool(page: Page, count = 1)
function selectZoomReset(page: Page)
function selectZoomOutTool(page: Page, count = 1)
@AlexeyGirin AlexeyGirin added refactor Code refactoring, without changing the functionality Autotests labels Jan 14, 2025
@AlexeyGirin AlexeyGirin assigned knadonenko and unassigned knadonenko Jan 14, 2025
@AlexeyGirin AlexeyGirin added this to the Autotests milestone Jan 14, 2025
@AlexeyGirin AlexeyGirin self-assigned this Jan 15, 2025
@AlexeyGirin AlexeyGirin linked a pull request Jan 15, 2025 that will close this issue
#6268 - fix for #6280 - Use separate build folder to run docker tests #6285
Merged
9 tasks
AlexeyGirin added a commit that referenced this issue Jan 15, 2025
@AlexeyGirin
#6268 - fix for #6280 - Use separate build folder to run docker tests (…
24517d3 
…#6285)

* first draft

* test 2

* test 2

* test 2.2

* fix

* last last fix
@AlexeyGirin AlexeyGirin reopened this Jan 15, 2025
YatsekTest pushed a commit that referenced this issue Jan 16, 2025
@AlexeyGirin @YatsekTest
#6268 - fix for #6280 - Use separate build folder to run docker tests (…
0746cba 
…#6285)

* first draft

* test 2

* test 2

* test 2.2

* fix

* last last fix
@YatsekTest YatsekTest linked a pull request Jan 17, 2025 that will close this issue
Autotests: #6268 - ZoomIn/ZoomOut/ZoomReset operations have been replaced with the valid… #6307
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YatsekTest YatsekTest

Labels
Autotests refactor Code refactoring, without changing the functionality
Projects
None yet
Milestone
Autotests
3 participants
@knadonenko @AlexeyGirin @YatsekTest