Suggestion: use Radix UI's <Slot /> instead of the ButtonLink component #195
Closed
andrecasal
started this conversation in
Ideas
Replies: 2 comments
-
I think this is a fair idea. However I believe shadcn has a button component and I've not yet looked at how that one is built. Let's solidify that first. |
Beta Was this translation helpful? Give feedback.
0 replies
-
This is done now |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We could use the Slot pattern to
And instead of having a
ButtonLink
andLabelButton
components, we could do:We could then do away with the
getButtonClassName()
and colocate everything in theButton
component.Beta Was this translation helpful? Give feedback.
All reactions