Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to using family as family class rather than string #438

Closed
athowes opened this issue Nov 15, 2024 · 0 comments · Fixed by #449
Closed

Revert to using family as family class rather than string #438

athowes opened this issue Nov 15, 2024 · 0 comments · Fixed by #449
Assignees
@athowes
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Nov 15, 2024

As discussed in #423 comments.

What needs to be done:

  • Revert to family as e.g. lognormal() in vignettes
  • And in default to function
  • And in test suite
  • Add back in tests that the string version works
  • Export common families so that brms:: isn't needed

This will fix #332 also.
@athowes athowes self-assigned this Nov 15, 2024
@athowes athowes added the high Required for next release label Nov 15, 2024
@athowes athowes mentioned this issue Nov 16, 2024
Merged
9 tasks
seabbs pushed a commit that referenced this issue Nov 19, 2024
@athowes
Issue #438: Use class as default for family and reexport common famil…
3991f2f 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here
seabbs pushed a commit that referenced this issue Jan 10, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
41dfb5e 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 8b6f99d3c05117cc2e5c8be1afc3627fb3619870 [formerly 7e594460374bbeef99ff031663befa07fe579e80]
Former-commit-id: 0f4a99d8a8b5e1e3be0d6a8e806e68597c05d7ca
seabbs pushed a commit that referenced this issue Jan 21, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
5d86fe0 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 3991f2f
Former-commit-id: ff40773bd7e215f5bea27216f841f2212a34b971
seabbs pushed a commit that referenced this issue Jan 21, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
cf08449 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 3991f2f
Former-commit-id: ff40773bd7e215f5bea27216f841f2212a34b971
seabbs pushed a commit that referenced this issue Jan 21, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
15b81cd 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 3991f2f
Former-commit-id: ff40773bd7e215f5bea27216f841f2212a34b971
seabbs pushed a commit that referenced this issue Jan 21, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
09f93b1 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 8b6f99d3c05117cc2e5c8be1afc3627fb3619870 [formerly 7e594460374bbeef99ff031663befa07fe579e80]
Former-commit-id: 0f4a99d8a8b5e1e3be0d6a8e806e68597c05d7ca
seabbs pushed a commit that referenced this issue Jan 21, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
cc3f47c 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 8b6f99d3c05117cc2e5c8be1afc3627fb3619870 [formerly 7e594460374bbeef99ff031663befa07fe579e80]
Former-commit-id: 0f4a99d8a8b5e1e3be0d6a8e806e68597c05d7ca
Former-commit-id: 09f93b1
seabbs pushed a commit that referenced this issue Jan 21, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
b4acfb4 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 3991f2f
Former-commit-id: ff40773bd7e215f5bea27216f841f2212a34b971
Former-commit-id: a4f827363f07f786eb8f3516a2b0b0b2030f3dfa [formerly 15b81cd]
Former-commit-id: 599a0c65a82aea0c82030dbb8a91dbd5d585041d
seabbs pushed a commit that referenced this issue Jan 21, 2025
@athowes
Issue #438: Use class as default for family and reexport common famil…
4dcdd97 
…ies and formula function (#449)

* Add 3 families and bf as reexports

* Use lognormal() as default and document it

* Use lognormal() not "lognormal"

* Stop with brms::bf and use bf

* Remove more calls to brms::lognormal that can be lognormal

* We are also exporting stats::Gamma

* Another one

* Document

* Use predictions in test of sex effect

* Can do this without predict_delay_pars

* Change to link function here

Former-commit-id: 3991f2f
Former-commit-id: ff40773bd7e215f5bea27216f841f2212a34b971
Former-commit-id: a4f827363f07f786eb8f3516a2b0b0b2030f3dfa [formerly 15b81cd]
Former-commit-id: 599a0c65a82aea0c82030dbb8a91dbd5d585041d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athowes athowes

Labels
high Required for next release
Projects
None yet
Milestone
No milestone
1 participant
@athowes