Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Null Value error #448

Open
danielruss opened this issue Jun 25, 2024 · 2 comments
Open

Modal Null Value error #448

danielruss opened this issue Jun 25, 2024 · 2 comments

Comments

@danielruss
Copy link
Member

useing Tony's test module:

[ERROR_EDIT] Validate Error Check Modal
|__|__|__|min=0 max=999 softedit=true modalif=value<70 modalvalue='Is this weight correct?'|
 
[HARD_EDIT!] Validate Hard Error Modal
|__|id=HARD_EDIT_1|
|__|id=HARD_EDIT_2|

Uncaught TypeError: Cannot set properties of null (setting 'innerText')
at textboxinput (questionnaire.js:557:19)
at HTMLInputElement.textBoxInput (questionnaire.js:422:3)
textboxinput @ questionnaire.js:557
textBoxInput @ questionnaire.js:422

@danielruss
Copy link
Member Author

two issues:

  1. the modal element id was wrong: should be softModalResponseBody
  2. There is a bootstrap 4/5 change with modal. In BS4 you use data-dismiss="modal" to hide the modal in BS5 you use data-bs-dismiss="modal". Because the PWA uses BS4 and Quest Dev tool uses BS5... add both. Consider if we should be using Bootstrap so deeply in quest, even though I really like it.

PR coming soon

danielruss added a commit that referenced this issue Jun 25, 2024
@danielruss
Copy link
Member Author

to be fix when the spanish implementation is merged. Keeping issue open until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant