Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON-RPC 0.8.0: DEPRECATED_CAIRO_ENTRY_POINT.offset should be an integer #2506

Open
kkovaacs opened this issue Jan 21, 2025 · 1 comment
Open

JSON-RPC 0.8.0: DEPRECATED_CAIRO_ENTRY_POINT.offset should be an integer #2506

kkovaacs opened this issue Jan 21, 2025 · 1 comment
Assignees
@kkovaacs
Labels
wontfix This will not be worked on
Milestone
JSON-RPC 0.8.0

Comments

@kkovaacs
Copy link
Contributor

kkovaacs commented Jan 21, 2025 •
edited
Loading

The 0.8.0-rc.2 specification has changed the definition of the offset property in DEPRECATED_CAIRO_ENTRY_POINT: starkware-libs/starknet-specs#257

Previously (including in the JSON-RPC 0.7 specification) this has been NUM_AS_HEX but now it's an integer.

Unfortunately we don't yet have SerializeForVersion for pathfinder_rpc::types::class::CairoContractClass, so it's not trivial to change the serialization format of the offset property.
@kkovaacs kkovaacs added this to the JSON-RPC 0.8.0 milestone Jan 21, 2025
@kkovaacs kkovaacs changed the title DEPRECATED_CAIRO_ENTRY_POINT.offset should be an integer JSON-RPC 0.8.0: DEPRECATED_CAIRO_ENTRY_POINT.offset should be an integer Jan 21, 2025
@kkovaacs kkovaacs self-assigned this Jan 30, 2025
@t00ts
Copy link
Contributor

t00ts commented Feb 6, 2025

Note: This won't happen. This issue can be closed as soon as the 0.8.0-rc.3 spec is out and rolls back this change

@t00ts t00ts added the wontfix This will not be worked on label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkovaacs kkovaacs

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
JSON-RPC 0.8.0
Development

No branches or pull requests
2 participants
@kkovaacs @t00ts