Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Fact #2884

Closed
BorghildSelle opened this issue Mar 14, 2025 · 1 comment
Closed

Refactor Fact #2884

BorghildSelle opened this issue Mar 14, 2025 · 1 comment
Assignees
@SanjayMVarier

Comments

@BorghildSelle
Copy link
Contributor

  • components > src >Fact to tailwind core> Fact

  • ones that uses it: pageComponents > shared > portableText > components> news > Fact to sections > Factbox

We try to keep the section web component names close to the names they have in sanity studio component.

refactoring and simplifying it from styled components to tailwind
@BorghildSelle BorghildSelle added the ⚙️ task A single task. If linked to a user story it is a sub-task. label Mar 14, 2025
@BorghildSelle BorghildSelle removed the ⚙️ task A single task. If linked to a user story it is a sub-task. label Mar 14, 2025
SanjayMVarier pushed a commit that referenced this issue Mar 18, 2025
♻️ updating imports in index file #2884
71b2e9b
SanjayMVarier pushed a commit that referenced this issue Mar 18, 2025
♻️ Refactored fact component #2884
6a1b532
SanjayMVarier pushed a commit that referenced this issue Mar 19, 2025
♻️ Simplifying Fact Componenet #2884
e4e7855
SanjayMVarier pushed a commit that referenced this issue Mar 20, 2025
♻️ Simplifying Fact Componenet #2884
f9b4206
SanjayMVarier pushed a commit that referenced this issue Mar 26, 2025
♻️ Removing text component #2884
0479734
SanjayMVarier pushed a commit that referenced this issue Mar 26, 2025
♻️ Rmoving unnecessary wrappers #2884
e228897
@meols
Copy link
Collaborator

meols commented Mar 28, 2025

@SanjayMVarier @BorghildSelle - is there anything for me to test on this? If so, please specify the test criteria.

SanjayMVarier added a commit that referenced this issue Mar 31, 2025
@SanjayMVarier
♻️ Changes in Formatting #2884
573c131
padms pushed a commit that referenced this issue Mar 31, 2025
@SanjayMVarier
Refactoring of fact component #2884 (#2893)
f123cd4 
* Initial Commit

* Changing the Folder Structure

* ♻️ updating imports in index file #2884

* ♻️ Simplifying Fact Componenet #2884

* ♻️ Removing text component  #2884

* ♻️ Removed unused divs and folders

* ♻️ Updated the formattings

---------

Co-authored-by: MV <[email protected]>
@padms padms closed this as completed Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SanjayMVarier SanjayMVarier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@padms @meols @BorghildSelle @SanjayMVarier