Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing UNRST file requires reading the entire file #511

Closed
berland opened this issue Nov 27, 2024 · 0 comments · Fixed by #512
Closed

Parsing UNRST file requires reading the entire file #511

berland opened this issue Nov 27, 2024 · 0 comments · Fixed by #512
Labels
bug Something isn't working

Comments

@berland
Copy link
Collaborator

berland commented Nov 27, 2024

This line:

res2df/res2df/grid.py

Line 202 in 5d1d58d

for vec in resdatafiles.get_rstfile().headers:

is exposed to the bug/limitation in equinor/resdata#1027

On big enough UNRST files, this leads to out-of-memory conditions.
@berland berland added the bug Something isn't working label Nov 27, 2024
@berland berland added this to SCOUT Nov 27, 2024
@berland berland moved this to In Progress in SCOUT Nov 27, 2024
@berland berland linked a pull request Nov 27, 2024 that will close this issue
Use resfo for parsing headers in UNRST file #512
Merged
@berland berland moved this from In Progress to Ready for Review in SCOUT Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in SCOUT Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
SCOUT
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use resfo for parsing headers in UNRST file equinor/res2df
1 participant
@berland