-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Historical vectors should be omitted from the dropdown #79
Comments
Note that checking for names ending with Julius suggested to check if a vector whose name ends with |
FYI: So checking for a counterpart is probably a good way to confirm that a vector is (very likely) to be historical, but not safe to be used to exclude the fact that it could be. Another tricky thing we have encountered in webviz-subsurface is that there are use cases for uncertainty in historical data (for example the distribtution of produced volumes between wells, measurement errors in gauges and etc). In that case, the historical data is an ensemble in itself. In webviz-subsurface we currently only plot the historical data for 1 realization and assume that it is descriptive for the ensemble, but if you are unlucky, it could be the P99 historical vector... Just to add to the mess and confusion 😉 |
I am in favor of filtering out the historical vectors from the drop down list, alternatively as a defaulted option (eg radio button). As Asgeir points out it is possible to construct cases for which the historical vectors differ over an ensemble but as of now these are non existing. I also agree that the heuristic is terrible, but Julius' suggestion would make it robust. Out of the box only historical vectors have first identifier ending with an H, however it is possible to define user defined summay vectors and I think these are allowed to end on an H. |
@eivindsm When you say non-existing, what do you mean? Allocation uncertainty is not that uncommon to use? You also have a few vectors that are not user defined, but still ends with an H. Some of the examples I found in a quick search (was quite a few more): Most of these examples are quite obscure, but the general assumption of |
My next question is then; do we want to persist the historical vectors at all by default? Or could it even be an option that they never hit storage? |
would say: If you haven't added any uncertainty to it, and you are in history, it is for sure value in it. But needs some discussion. Think in the current plotter, the hated refcase is used to plot the historical vectors? |
We should be able to plot it, the question is whether we need to store n-ens copies. As Asgeir suggests there could be situations for which they are not identical over the realizations. If we are to support the sort of functionality prototyped in nyb-viz we also need access to them. I'd say, yes we should persist them. |
As Asgeir points out, the heuristics is terrible. It also seems that I have to modify my claim that uncertainty in allocation is nonexistent. My suggestion would be to have a radio button to filter *H vectors out from the drop down list similar to the option we already have filtering out responses without corresponding observations. |
Implementing a version of this with the suggested checkbox filtering out all keys ending on |
Should just be default added to the summary vector
The text was updated successfully, but these errors were encountered: