Implement draft/message-redaction #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2023 16:12
Permission to use REDACT mirrors permission for 'HistServ DELETE'
slingamn
reviewed
May 28, 2023
| // length of the uint32 array that represents the bitset: | ||
| bitsetLen = 1 | ||
| bitsetLen = 2 |
Makefile
Outdated
| go install -v -ldflags "-X main.commit=$(GIT_COMMIT) -X main.version=$(GIT_TAG)" | ||
|
|
||
| build: | ||
| build: ${capdef_file} |
There was a problem hiding this comment.
I'd rather we didn't, this just slows down the build in the normal case?
There was a problem hiding this comment.
it's only a stat() call...
There was a problem hiding this comment.
(Make won't rebuild a target if a file with the same name already exists and is more recent than its dependencies)
There was a problem hiding this comment.
Oh right, I normally don't use this feature of make (I normally do 100% phony targets). I would prefer if we didn't introduce it because I don't understand it very well :-|
added 5 commits
May 29, 2023 13:54
slingamn says it's probably not desirable, and I'm on the fence. Out of laziness, let's omit it for now, as it's not a regression compared to '/msg HistServ DELETE'.
slingamn
requested changes
May 31, 2023
Comment on lines
+2729
to
+2730
| // If this is a PM, we just removed the message from the buffer of the other party; | ||
| // now we have to remove it from the buffer of the client who sent the REDACT command |
This reverts commit 2182b1d.
This was referenced May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permission to use REDACT mirrors permission for 'HistServ DELETE'
Spec: ircv3/ircv3-specifications#524 (this is a variant of ircv3/ircv3-specifications#425 with only deletion/redaction, and targetmsg moved from a tag to a parameter)
Tests: progval/irctest#203
@slingamn Thoughts on this design before I add support for PMs?