Compatibility with dm's tests

[krlmlr]

I see, in the dev version, that the genre table has changed, and that the pixar_films table no longer has a missing value. The dm package makes certain assumptions about the structure of the data, and so might other users. Curious to hear your thoughts on how to deal with that.

Releasing dm 1.0.11 now, but I can push an update on short notice if needed.

[erictleung]

@krlmlr thanks for the issue. I did notice this too for the dm package as I was doing some testing.

The breaking change for the genres table is to expand the table a bit. I don't expect to change it that often. But I'm finally doing an update of the data, so I found some extra subgenres that I wanted, hence the breaking change.

Happy to make the updates to dm package function. The schema for the genres data is now three columns: film, category, value.

Regarding pixar_films no longer having missing data, that was a feature of at the time, Pixar didn't realize the title of the film. But now, the table I'm pulling from has all the films named. And I don't include any unreleased films anymore. So, for this issue, I'm not sure you want to work around this.

[krlmlr]

I'm also relying on the pixarfilms package for workshop material...

How do you feel about creating functions to access the data, instead of exposing the data as package objects? This would allow for an argument to specify the "edition" of the data. Happy to send a PR.

[erictleung]

@krlmlr Ah I see. Mmm creating functions to access the data seems cumbersome imo, especially when as new movies come out, then I'll try to update the data accordingly. But if you have an example of how that looks, I would be curious to see how that's implemented. I've not implemented or seen a solution like that. I'm intrigued.

Otherwise, the CRAN version should still have the data with some of the "errors" or particular structures of the data that you should expect. And because I had to set a tag for that release, for your workshops, you can target that particular release if needed.

remotes::install_github("erictleung/pixarfilms@v0.2.1")

Let me know what you think