Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception when parsing object literals containing arrow functions #116

Open
gabejohnson opened this issue Jun 19, 2020 · 2 comments · May be fixed by #117
Open

Exception when parsing object literals containing arrow functions #116

gabejohnson opened this issue Jun 19, 2020 · 2 comments · May be fixed by #117

Comments

@gabejohnson
Copy link

I noticed a parse error when parsing an object literal containing an arrow function if any properties are defined after the arrow function.

({ f: x => x }) // no error

({ x: null, f: x => x }) // no error

({ f: (x => x), x: null }) // no error

({ x: true ? 1 : 0, y: null }) // no error

({ f: x => x, x: null }) // ColonToken {tokenSpan = TokenPn 163 9 16, tokenComment = []}

Since the third example parses without error, my suspicion is that the, in the failing example is being parsed as a comma operator and thus the colon after x is unexpected.

The behavior also appears to be restricted to arrow functions as the fourth example contains an expression which doesn't cause a failure.
@gabejohnson
Copy link
Author

gabejohnson commented Jun 27, 2020 •
edited
Loading

I've also found a strange interplay between arrow functions and template literals:

0;``
// JSAstModule [JSModuleStatementListItem (JSDecimal '0',JSSemicolon),JSModuleStatementListItem (JSTemplateLiteral ((),'``',[]))]

()=>{};''
// JSAstModule [JSModuleStatementListItem (JSArrowExpression (()) => JSStatementBlock []),JSModuleStatementListItem (JSStringLiteral '')]

()=>{}``
// JSAstModule [JSModuleStatementListItem (JSTemplateLiteral ((JSArrowExpression (()) => JSStatementBlock []),'``',[]))]

()=>{};``
// JSAstModule [JSModuleStatementListItem (JSTemplateLiteral ((JSArrowExpression (()) => JSStatementBlock []),'``',[]))]

()=>{}
``
// JSAstModule [JSModuleStatementListItem (JSTemplateLiteral ((JSArrowExpression (()) => JSStatementBlock []),'``',[]))]

Example 1 (no arrow function with a template literal) parses as expected. So does example 2 (arrow function with no template literal).

Example 3 shouldn't parse, but does. The template literal should cause a syntax error.

Example 4 should parse but not as a labeled template literal. The semicolon appears to be ignored.

Example 5 should parse but not in the same way as 3 and 4. ASI doesn't appear to be respected in this case.

@gabejohnson
Copy link
Author

I have a branch which fixes all of these cases. @erikd would you accept a PR?

@gabejohnson gabejohnson linked a pull request Jul 4, 2020 that will close this issue
Open
@gabejohnson gabejohnson mentioned this issue Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix arrow function body parsing gabejohnson/language-javascript
1 participant
@gabejohnson