Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language-javascript-0.7.1.0 should have been 0.8.0.0 #130

Open
cdepillabout opened this issue Nov 8, 2021 · 0 comments
Open

language-javascript-0.7.1.0 should have been 0.8.0.0 #130

cdepillabout opened this issue Nov 8, 2021 · 0 comments

Comments

@cdepillabout
Copy link

It appears language-javascript follows the PVP. Version 0.7.1.0 was recently released, which bumps from 0.7.0.0.

However, 0.7.1.0 includes #113, which adds new data constructors to an exported data type.

I asked about this on the Haskell discourse, and it appears there is a (small amount of) consensus that adding a new data constructor requires a major version bump: https://discourse.haskell.org/t/does-adding-a-data-constructor-require-a-major-version-bump-according-to-the-pvp/3600/3

So 0.7.1.0 should have been 0.8.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant