Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google.Latin removes trailing comma when it shouldn't #18

Open
ahus1 opened this issue Jul 1, 2022 · 0 comments
Open

Google.Latin removes trailing comma when it shouldn't #18

ahus1 opened this issue Jul 1, 2022 · 0 comments

Comments

@ahus1
Copy link

ahus1 commented Jul 1, 2022

When I have the following text in a Markdown file:

This is, e.g., some more dummy text.

Then Vale will suggest the following correction:

This is, for example some more dummy text.

Thereby removing the trailing comma which it shouldn't remove AFAIK and according to this page: https://english.stackexchange.com/questions/16172/should-i-always-use-a-comma-after-e-g-or-i-e

When going to the URL https://developers.google.com/style/abbreviations there are even some "for example" with a comma after them.

When using "e.g." without a trailing comma, it will remove the following blank:

This is, e.g. some more dummy text.

Then Vale will suggest the following correction:

This is, for examplesome more dummy text.

I talked to a friend, and he suggested a zero-width-lookahead instead, replacing [\s,] with ?=[\s,] in Google/Latin.yml

Once there is an agreement how the result should be, I'd be happy to provide a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant