Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Vale problem output in VS Code does not match CLI, despite being set to use CLI #62

Open
stewartadam opened this issue Oct 14, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@stewartadam
Copy link

After installing VS Code and configuring a .vale.ini in the repo root, the output of vale . and the problems highlighted by the editor are different. Namely, the problems from styles (Microsoft's in this case) are not included in the problem highlights.

@jdkato
Copy link
Member

jdkato commented Oct 14, 2021

Is this true for individual files?

The command vale . will show alerts for the entire directory, while the extension only shows them for open files.

@stewartadam
Copy link
Author

You're right, looks like this is a UX issue around native VSCode functionality and how I expected the extension to operate.

Problem reports within the file are accurately reported in full, however unchecking "Show active file only" in the filters continues to only show problem reports for the current file, not the full output for all files that vale . shows as I was expecting:
image

@jdkato jdkato added the enhancement New feature or request label Oct 25, 2021
@ChrisChinchilla
Copy link
Collaborator

Is the suggestion here to change the extension docs I guess?

@stewartadam
Copy link
Author

I guess it depends if we want to consider this bugfix (adjust the docs, preserve current behavior) or a feature request (ensure problem output matches the same as running vale in the workspace, not the current file).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants