card->ssPin to LOW in sdcard_unmount()?

[etkaar]

Board

ESP32-S3

Device Description

In sdcard_init() there is a digitalWrite(card->ssPin, HIGH) but in sdcard_unmount() there is no digitalWrite(card->ssPin, LOW), is that intended?

See: https://github.com/espressif/arduino-esp32/blob/master/libraries/SD/src/sd_diskio.cpp#L710C3-L710C21

Hardware Configuration

Not applicable

Version

v3.0.7

IDE Name

Arduino IDE

Operating System

GNU/Linux

Flash frequency

40MHz

PSRAM enabled

yes

Upload speed

115200

Description

Not applicable

Sketch

Not applicable

Debug Message

Not applicable

Other Steps to Reproduce

No response

I have checked existing issues, online documentation and the Troubleshooting Guide

• I confirm I have checked existing issues, online documentation and Troubleshooting guide.

[me-no-dev]

digitalWrite(card->ssPin, HIGH) is done in init just to make sure that the bus is properly set. From then on the SS pin is handled internally.