We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with escodegen.attachComments (and maybe also with esprima.parse). See https://github.com/estools/escodegen/blob/master/test/comment.js or #427 PR for reproduction.
escodegen.attachComments
esprima.parse
Input:
function foo(a, b, c) { return ( (a >= b && a <= c) // lorem // ipsum || a === 42 || a === 666 ); }
Output:
function foo(a, b, c) { return a >= b && a <= c || a === 42 || a === 666; }
Suggested output:
function foo(a, b, c) { // lorem // ipsum return a >= b && a <= c || a === 42 || a === 666; }
The text was updated successfully, but these errors were encountered:
the more problematic scenario is when having an arrow function returning an object expression in this scenario the generated code is actually invalid
() => ( // comment { a: 1, b: 2 })
output:
() => // comment { a: 1, b: 2 });
suggested output:
() => ( // comment { a: 1, b: 2 )});
Sorry, something went wrong.
@Meir017 looks like this belongs to the related issue #365. Nice catch!
@lucivpav we also need to support this syntax: var a = b => ({}.hasOwnProperty.call(b, "c")); which actually translates to a CallExpression
var a = b => ({}.hasOwnProperty.call(b, "c"));
No branches or pull requests
Problem with
escodegen.attachComments
(and maybe also withesprima.parse
). See https://github.com/estools/escodegen/blob/master/test/comment.js or #427 PR for reproduction.Input:
Output:
Suggested output:
The text was updated successfully, but these errors were encountered: