Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impose test format verification after fill #940

Open
winsvega opened this issue Nov 5, 2024 · 2 comments
Open

impose test format verification after fill #940

winsvega opened this issue Nov 5, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers scope:fill Scope: fill command type:feat type: Feature

Comments

@winsvega
Copy link
Collaborator

winsvega commented Nov 5, 2024

looks like evmone-t8n generated genesis with "baseFeePerGas": "0x00", on frontier network

so we need to check the generated test format with consume. like I did with retesteth. if blockchain test is of network frontier. the genesis must not have other fork fields
and vice versa. this is not being checked. I am getting test with genesis header with baseFeePerGas when using evmonet8n

@danceratopz
Copy link
Member

Currently evmone's t8n returns invalid block header fields for Frontier (to be double-checked by @winsvega) - this is blocking #808.

@winsvega winsvega self-assigned this Nov 22, 2024
@winsvega winsvega added good first issue Good for newcomers type:feat type: Feature scope:fill Scope: fill command labels Dec 2, 2024
@winsvega
Copy link
Collaborator Author

winsvega commented Dec 2, 2024

ethereum/evmone#1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers scope:fill Scope: fill command type:feat type: Feature
Projects
None yet
Development

No branches or pull requests

2 participants