You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
"Special case, the execution of the initcode and gas "
"cost to deploy are zero: Then this test case is "
"equivalent to that of 'test_exact_intrinsic_gas'."
)
The resulting fixtures should be verified via uv run hasher with and without the refactor (all hashes bar the top-level folder should stay the same). For easy verification, it will be necessary that the existing test IDs from the valid cases are maintained and not rearranged, by careful ordering of the parameters.
The same technique can be applied to this test function as for ipsilon#5.
The text was updated successfully, but these errors were encountered:
@danceratopz, If we have to do multilple refactoring
I.e., these lines must be made unnecessary and removed:
what if we filter out invalid test cases during the test setup phase, ensuring only valid combinations are generated?
or maybe can Create a helper function to determine if a test case is valid and then use this function to filter out invalid test cases during parametrization?
Skipped tests when filling (for invalid parameter sets) unnecessarily pollute the console and are confusing for users.
Some examples can be found via:
The following test cases should never get created by creating a list of valid test cases via a helper test function:
I.e., these lines must be made unnecessary and removed:
execution-spec-tests/tests/shanghai/eip3860_initcode/test_initcode.py
Lines 318 to 322 in e546b9c
The resulting fixtures should be verified via
uv run hasher
with and without the refactor (all hashes bar the top-level folder should stay the same). For easy verification, it will be necessary that the existing test IDs from the valid cases are maintained and not rearranged, by careful ordering of the parameters.The same technique can be applied to this test function as for ipsilon#5.
The text was updated successfully, but these errors were encountered: