-
Notifications
You must be signed in to change notification settings - Fork 20.8k
Implement EIP 4361 #24132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @holiman @MariusVanDerWijden i m interested in contributing to geth! I want to take this issue up to implement this EIP! |
please feel free to assign to me. I ll keep communication on my status in this thread |
I am interested too. |
The main task is to rewrite siwe code written in TS into Go and make it work in geth? |
I started implementing it, found some spec issues. https://ethereum-magicians.org/t/eip-4361-sign-in-with-ethereum/7263/9?u=holiman |
@holiman Hi. I'm interested to take this issue. Is it still relevant? And what about the issue that you mentioned above. Does it still exist? |
Hi there! is it still actual? |
hi , can i take on this issue ? |
@holiman does it worth to take it? |
@holiman Hi, I noticed this issue regarding EIP-4361 doesn't have an implementation yet. |
Please don't ask if you can implement something, just send a PR! |
Hi @holiman, I am an Ethereum newcomer and have submitted a PR that implements the SIWE (Sign-In With Ethereum) validator discussed here: #31722. The validator provides lightweight internal parsing and verification of EIP-4361 fields, without relying on external libraries, following the design philosophy discussed in this issue. This PR is now ready for review. Thank you very much for your guidance and support! |
We should look into implementing EIP 4361 in Clef:
This should already work out of the box (since it's just signing a text message), however:
Reference implementation + testcases here: https://github.com/spruceid/siwe
The text was updated successfully, but these errors were encountered: