Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for debug tracing methods #30833

Open
s1na opened this issue Nov 28, 2024 · 8 comments
Open

Write tests for debug tracing methods #30833

s1na opened this issue Nov 28, 2024 · 8 comments

Comments

@s1na
Copy link
Contributor

s1na commented Nov 28, 2024

We have only partial coverage for our tracing API. Specially I am concerned the methods that are useful only when something goes wrong, e.g. debug_standardTraceBlockToFile, debug_standardTraceBadBlockToFile, debug_intermediateRoots are out of date and we might find ourselves not being able to use them when they are needed. We have some tests in eth/tracers/api_test.go. We should expand them to cover at least these 3 methods + debug_traceBadBlock.

@MukulKolpe
Copy link

Hey @s1na, can I work on this one?

@s1na
Copy link
Contributor Author

s1na commented Nov 28, 2024

Sure @MukulKolpe go ahead.

@gerceboss
Copy link

@s1na , would like to work on this, can you please assign me if there is not any progress on it. Might need some guidance along the way.

@s1na
Copy link
Contributor Author

s1na commented Dec 12, 2024

@gerceboss I don't know if @MukulKolpe is still working on this. But even if we have 2 sets of tests it's not so bad. So please feel free to check it out in the meanwhile.

@sina-haseli
Copy link

@s1na I'm still familiarizing myself with the project and wanted to contribute by starting with something valuable like testing. While I'm not entirely sure if the tests I've added are sufficient or fully aligned with the project's needs, I'd appreciate feedback. If these changes are helpful, I’d be happy to iterate and refine further or work on additional tasks.

Looking forward to your thoughts!

@s1na
Copy link
Contributor Author

s1na commented Dec 13, 2024

While I'm not entirely sure if the tests I've added are sufficient or fully aligned with the project's needs, I'd appreciate feedback. If these changes are helpful, I’d be happy to iterate and refine further or work on additional tasks.

Salam @sina-haseli 😃 Have you pushed these tests somewhere I can see? I checked the PR list and see nothing from you.

@sina-haseli
Copy link

While I'm not entirely sure if the tests I've added are sufficient or fully aligned with the project's needs, I'd appreciate feedback. If these changes are helpful, I’d be happy to iterate and refine further or work on additional tasks.

Salam @sina-haseli 😃 Have you pushed these tests somewhere I can see? I checked the PR list and see nothing from you.

Salam @s1na 😃
Thank you for checking in! I just added the tests and pushed them. You should be able to see them now. Please let me know if there's anything you'd like me to adjust or improve. 😊

@sfsf9797
Copy link

sfsf9797 commented Dec 21, 2024

Hi @s1na, I am going to add another set for this. Let me know if you think it is not necessary. Thanks 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants