-
Notifications
You must be signed in to change notification settings - Fork 20.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write tests for debug tracing methods #30833
Comments
Hey @s1na, can I work on this one? |
Sure @MukulKolpe go ahead. |
@s1na , would like to work on this, can you please assign me if there is not any progress on it. Might need some guidance along the way. |
@gerceboss I don't know if @MukulKolpe is still working on this. But even if we have 2 sets of tests it's not so bad. So please feel free to check it out in the meanwhile. |
@s1na I'm still familiarizing myself with the project and wanted to contribute by starting with something valuable like testing. While I'm not entirely sure if the tests I've added are sufficient or fully aligned with the project's needs, I'd appreciate feedback. If these changes are helpful, I’d be happy to iterate and refine further or work on additional tasks. Looking forward to your thoughts! |
Salam @sina-haseli 😃 Have you pushed these tests somewhere I can see? I checked the PR list and see nothing from you. |
Salam @s1na 😃 |
Hi @s1na, I am going to add another set for this. Let me know if you think it is not necessary. Thanks 😊 |
We have only partial coverage for our tracing API. Specially I am concerned the methods that are useful only when something goes wrong, e.g. debug_standardTraceBlockToFile, debug_standardTraceBadBlockToFile, debug_intermediateRoots are out of date and we might find ourselves not being able to use them when they are needed. We have some tests in
eth/tracers/api_test.go
. We should expand them to cover at least these 3 methods + debug_traceBadBlock.The text was updated successfully, but these errors were encountered: