Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: align overflow checks in IntrinsicGas #30931

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

core: align overflow checks in IntrinsicGas #30931

wants to merge 1 commit into from

Conversation

Kourin1996
Copy link

Fixes #30880

This PR fixes calculations in the IntrinsicGas function that do not care abount overflow, ensuring they handle overflow in the same way as other computations in the same function

jwasinger
jwasinger reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@jwasinger jwasinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that any case where this could possibly overflow would have to be caused by an access list that is impossibly massive. So it doesn't appear worth it to increase the code complexity in order to handle a situation that can never arise.

@jwasinger
Copy link
Contributor

Similarly, auths from 7702 have sufficient size that the overflow checks this EIP adds can never realistically be triggered there either.

@palango
Copy link
Contributor

palango commented Dec 20, 2024

Similarly, auths from 7702 have sufficient size that the overflow checks this EIP adds can never realistically be triggered there either.

True, but it might make sense to align handling of those checks. See also this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwasinger jwasinger jwasinger left review comments

@holiman holiman Awaiting requested review from holiman holiman is a code owner

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing overflow check for AccessList cost addition in IntrinsicGas function
3 participants
@Kourin1996 @jwasinger @palango