Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setCode transaction type tests for eth_call and estimateGas #30920

Open
s1na opened this issue Dec 16, 2024 · 6 comments · May be fixed by #30947
Open

setCode transaction type tests for eth_call and estimateGas #30920

s1na opened this issue Dec 16, 2024 · 6 comments · May be fixed by #30947

Comments

@s1na
Copy link
Contributor

s1na commented Dec 16, 2024

User should be able to estimateGas/simulate a setCode transaction type (EIP-7702). That goes for eth_call, eth_estimateGas and eth_simulate.

@UnionSummer09
Copy link

Nice

@rjl493456442
Copy link
Member

Probably also trace_call?

@DarkLord017
Copy link

Hi @s1na,
I’d love to work on this issue! I might need a bit of guidance along the way.

@s1na
Copy link
Contributor Author

s1na commented Dec 19, 2024

@DarkLord017 Actually I believe most of the code was there I just missed it and the missing piece was added as part of 06dfb42#diff-4a9c1433c7c79c50cb72fd743c896f7bf5a976f46ccbb5fae83f5c46b2465db9. So If you'd like to contribute tests for this new tx type in internal/ethapi/api_test.go please feel welcome to do that.

@s1na s1na changed the title eth_call and estimateGas for setCode transaction types setCode transaction type tests for eth_call and estimateGas Dec 19, 2024
@DarkLord017
Copy link

DarkLord017 commented Dec 19, 2024

@DarkLord017 Actually I believe most of the code was there I just missed it and the missing piece was added as part of 06dfb42#diff-4a9c1433c7c79c50cb72fd743c896f7bf5a976f46ccbb5fae83f5c46b2465db9. So If you'd like to contribute tests for this new tx type in internal/ethapi/api_test.go please feel welcome to do that.

Sure ! I would love to contribute to it

@DarkLord017
Copy link

@s1na I added basic test for to check the call functionality like they were written for estimate gas function what more functions can i test or what more things can i add on ?
I want to ensure the test coverage is thorough and would appreciate it if you could provide some suggestions or point me to resources that might help me identify additional scenarios to test.
and are there any other function that i can write tests for this new tx type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants