fix: improve NAT handling in kubernetes environments" #30962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucwong
reviewed
Dec 27, 2024
| func (n ExtIP) ExternalIP() (net.IP, error) { return net.IP(n), nil } | ||
| func (n ExtIP) ExternalIP() (net.IP, error) { | ||
| if IsKubernetesEnvironment() { | ||
| return net.IP(n), nil |
There was a problem hiding this comment.
en .. I think it is the same of return, whetherIsKubernetesEnvironment or not in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #30945 by improving NAT handling in Kubernetes environments. When running in K8s, the node should trust the externally provided IP address since container networking and service mesh handle NAT traversal.
Changes
Testing
Related Issues
Fixes #30945
Backwards Compatibility
This change is fully backwards compatible as it only affects behavior in Kubernetes environments.