Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check why the bytecode lengths are changing in the "extra_file_input" bug tests #1947

Open
kuzdogan opened this issue Feb 24, 2025 · 0 comments

Comments

@kuzdogan
Copy link
Member

During the PR #1879 we introduced a check on the bytecode lengths during verification ie. if bytecode lengths don't match we assume these contracts don't match.

However after implementing this the test "should detect extra file input bug when optimizer is enabled" started to fail because apparently the bytecode lengths are different for the onchain contract vs. recompiled with extra files.

To my understanding this shouldn't have happened because the bug is only affecting the AST IDs, and the bytecode lengths should've stayed the same. We should investigate what the real issue is or if our understanding was wrong.

@kuzdogan kuzdogan moved this from Triage to Backlog in Sourcify Public Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant