Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serving the swagger docs is broken #1953

Open
manuelwedler opened this issue Feb 27, 2025 · 0 comments · May be fixed by #1956
Open

Serving the swagger docs is broken #1953

manuelwedler opened this issue Feb 27, 2025 · 0 comments · May be fixed by #1956
Assignees
@manuelwedler
Labels
🪲 bug Something isn't working

Comments

@manuelwedler
Copy link
Contributor

manuelwedler commented Feb 27, 2025 •
edited
Loading

I realized that the error handling PR for API v2 (#1946) broke our Swagger UI docs.

See https://staging.sourcify.dev/server/api-docs/

returns:

{"customCode":"route_not_found","message":"The requested resource was not found","errorId":"cd41cfb4-b40e-4c3e-95f3-42f3a83bfe87"}

Seems like the swagger docs route is matched later than the 404 fallback.
@manuelwedler manuelwedler added the 🪲 bug Something isn't working label Feb 27, 2025
@manuelwedler manuelwedler moved this from Triage to Sprint - In Progress in Sourcify Public Feb 27, 2025
@manuelwedler manuelwedler self-assigned this Feb 27, 2025
@manuelwedler manuelwedler linked a pull request Feb 28, 2025 that will close this issue
Open
@manuelwedler manuelwedler moved this from Sprint - In Progress to Sprint - Needs Review in Sourcify Public Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuelwedler manuelwedler

Labels
🪲 bug Something isn't working
Projects
Sourcify Public
Status: Sprint - Needs Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move api-docs route before fallback handler ethereum/sourcify
1 participant
@manuelwedler