Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Cooldown timer. Closes #126. #152

Closed

Conversation

TheCrowbill
Copy link
Member

Added setup job for cooldown timer and Tweet timestamping.

Added `setup` job for cooldown timer and Tweet timestamping.
@TheCrowbill TheCrowbill marked this pull request as draft December 17, 2022 08:32
@TheCrowbill TheCrowbill linked an issue Dec 17, 2022 that may be closed by this pull request
@TheCrowbill TheCrowbill self-assigned this Dec 18, 2022
@TheCrowbill TheCrowbill added the enhancement New feature label Dec 18, 2022
@DonaldMcIntyre DonaldMcIntyre self-requested a review March 23, 2023 12:13
@IstoraMandiri
Copy link
Collaborator

IstoraMandiri commented May 22, 2023

@TheCrowbill may I ask what is the status on this?

We could also use https://github.com/marketplace/actions/merge-schedule and/or in conjunction with the contribunator bot if we need to add any custom logic to get things to work well together.

Ideally we'd give tweet submitters the option of setting a future publish (merge) date, but that is also using some kind of cooldown between tweets.

Edit: I think the easiest solution here will be to update the merge-schedule action slightly to add a cooldown option and auto-merge all approved PRs with this logic. I'll look into this, but would like to hear from crowbill also.

@TheCrowbill
Copy link
Member Author

@TheCrowbill may I ask what is the status on this?

I looked at doing this from several different directions and ran into a dead end or more serious obstacles than I was equipped to overcome.

First, I tried to find a method to incorporate the cooldown into the repo's Actions but that proved to be less than ideal. While it could theoretically be done from the Actions alone, the implementation would be crude and not very user-friendly.

The other method I investigated would involve modifications to the JacaScript itself. While this would produce the most versatile and functional solution, unfortunately, the portion of the Twitter-Together Action that would require modification is not in this repo or fork. Rather, it is the GitHub Action itself that would require the modification, the code for which is in excess of 30,000 lines.

I started then looking for third-party solutions and came up empty.

We could also use https://github.com/marketplace/actions/merge-schedule and/or in conjunction with the contribunator bot if we need to add any custom logic to get things to work well together.

Ideally we'd give tweet submitters the option of setting a future publish (merge) date, but that is also using some kind of cooldown between tweets.

Edit: I think the easiest solution here will be to update the merge-schedule action slightly to add a cooldown option and auto-merge all approved PRs with this logic. I'll look into this, but would like to hear from crowbill also.

With your PR automation, this would likely be the best place to put in the cooldown delay. If you want the added functionality of specific scheduling, I still think that the base code may need modification or the Action may run continuously.

I will close this draft PR and we can address Issue #126 in a new one.

@IstoraMandiri
Copy link
Collaborator

Thanks for the detailed response @TheCrowbill !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cooldown timer
3 participants