-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Cooldown timer. Closes #126. #152
[WIP] Cooldown timer. Closes #126. #152
Conversation
Added `setup` job for cooldown timer and Tweet timestamping.
@TheCrowbill may I ask what is the status on this? We could also use https://github.com/marketplace/actions/merge-schedule and/or in conjunction with the contribunator bot if we need to add any custom logic to get things to work well together. Ideally we'd give tweet submitters the option of setting a future publish (merge) date, but that is also using some kind of cooldown between tweets. Edit: I think the easiest solution here will be to update the merge-schedule action slightly to add a cooldown option and auto-merge all approved PRs with this logic. I'll look into this, but would like to hear from crowbill also. |
I looked at doing this from several different directions and ran into a dead end or more serious obstacles than I was equipped to overcome. First, I tried to find a method to incorporate the cooldown into the repo's Actions but that proved to be less than ideal. While it could theoretically be done from the Actions alone, the implementation would be crude and not very user-friendly. The other method I investigated would involve modifications to the JacaScript itself. While this would produce the most versatile and functional solution, unfortunately, the portion of the Twitter-Together Action that would require modification is not in this repo or fork. Rather, it is the GitHub Action itself that would require the modification, the code for which is in excess of 30,000 lines. I started then looking for third-party solutions and came up empty.
With your PR automation, this would likely be the best place to put in the cooldown delay. If you want the added functionality of specific scheduling, I still think that the base code may need modification or the Action may run continuously. I will close this draft PR and we can address Issue #126 in a new one. |
Thanks for the detailed response @TheCrowbill ! |
Added
setup
job for cooldown timer and Tweet timestamping.