-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Local mapping via rolling window approach #25
Comments
Thank you! I'm glad to hear it's useful.
|
Hello and sorry for the late reply. Yes, we have already found that hashed-octree works much better and will very likely use it in the future. Since my requested feature could obviously be easily implemented for hashed-octree, I already thought of doing it myself. But then I decided to coordinate with you on what your plans are. I assume that you can implement it even faster and cleaner in your framework :-).
To answer your questions, yes and yes. We are concerned about the memory consumption due to the small compute units used. Also, there may still be localization drift, so revisiting the same location multiple times would mess up the map without closed loop optimization. So in our case we are more interested in hard distance thresholding, but I can also see interesting use cases for time thresholding (aging out old nodes). |
Hi Alexander, |
The draft is now available on the feature/local_mapping branch. I tested it with these general settings:
Let me know how it works for you, and feel free to modify the code :) |
Awesome! Thank you so much for your efforts! I'm currently very busy but definitely will take a look into that asap.
We are using currently Jetson Xavier as compute units. |
Welcome! No rush :)
Oh nice, we're using Xavier's on our drones as well. |
Hi Alexander, we're considering merging the local mapping feature into a release sometime in the next two weeks. Did you have a chance to try it? Are there any options that you'd like to use but are still missing? |
My plan is to test this out next week using real robots :-). |
Hi Victor, Finally, I've tested this branch. Looks great so far! I have already some feedback for you:
Thanks for your great work! |
Hi Alexander,
|
|
Cannot await to see that feature merged soon! :-) |
We don't have a method to introspect this yet. One option would be to add a member method to the data structures along the lines of
We're planning to review and merge this feature once PR#37 is ready :) |
@astumpf, I just wanted to update you on our timeline. We're planning to refactor the wavemap_server, to make the additional operations it can perform more modular and extendable. This new structure will also provide a cleaner way to incorporate the code and configuration options for the sliding window functionality, so we plan to release the sliding window feature and refactored server together - probably around mid-November. |
I am very excited, looking forward to it! |
The new wavemap_server structure on the feature/plugin_system branch now supports local mapping through a map cropping plugin. It can be enabled and configured by adding an entry of Taking the default Ouster OS0 config for illustration, you could replace the operations array with:
The main advantage we see is that it groups all the relevant settings in one place and improves the internal structure of the wavemap server. It also makes it easy to add additional plugins in the future, including custom plugins by users. Would this new structure work well for you? |
Definitely yes. I like the new structure. Does that mean we can also add new plugins ourselves? |
Yes, that would be the goal. The idea so far is that users can create classes derived from InputBase or OperationBase, and then register them with the wavemap server by calling something like |
Thank you very much for the great effort you put into wavemap! It is a great new tool!
I wonder if there are any plans for local mapping, like a rolling window approach. That would be a nice feature where nodes that are too far away from the moving robot are automatically pruned.
The text was updated successfully, but these errors were encountered: