This repository has been archived by the owner on Dec 18, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to match wildcard metric patterns in the analyzer.py alert context.
Currently the alert matching is a one to one relationship - metric -> alert setting.
Therefore it is not possible to map wildcarded metrics to a single ALERT and strategy settings e.g.
metrics namespaces:
stats.publishers.alice.rpm
stats.publishers.bob.rpm
Currently we would have to define an individual ALERT for each metric
and an individual strategy for each whether in the SMTP_OPTS or otherwise
This change to using python re and not
if alert[0] in metric[1]
allows for both the current functionality, but it extends the alerting to allow wildcarded namespaces to one alert settingThis allows much more granular and configurable alerting
This does not break any functionality and fits with the current
cache_key = 'last_alert.%s.%s' % (alert[1], metric[1])