Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting Name and Icon by Search URL doesn't work #7

Open
532910 opened this issue Feb 1, 2019 · 1 comment
Open

getting Name and Icon by Search URL doesn't work #7

532910 opened this issue Feb 1, 2019 · 1 comment

Comments

@532910
Copy link

532910 commented Feb 1, 2019

https://github.com/soufianesakhi/firefox-search-engines-helper
Entering https://search.f-droid.org/?q=%s into Search URL will fill Name with search.f-droid.org and Icon with https://www.google.com/s2/favicons?domain=search.f-droid.org

Add custom search engine will not set Name with "Please fill out this name" error.
Will fill wrong Icon URL: https://search.f-droid.org/favicon.ico

@evilpie
Copy link
Owner

evilpie commented Feb 1, 2019

https://github.com/soufianesakhi/firefox-search-engines-helper
Entering https://search.f-droid.org/?q=%s into Search URL will fill Name with search.f-droid.org and Icon with https://www.google.com/s2/favicons?domain=search.f-droid.org

Add custom search engine will not set Name with "Please fill out this name" error.

I am not convinced yet that auto-filling the name is useful enough.

Will fill wrong Icon URL: https://search.f-droid.org/favicon.ico

Yeah, that kind of sucks. I don't have a good idea on how to fix this without using the Google service like "Search engine helper", or actually fetching the search URL. Auto-filling the icon is more of a best effort kind of thing. I am almost tempted to remove it, but it does work for a lot of websites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants