Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows code is probably still not quite right #4

Open
evilpie opened this issue Aug 2, 2018 · 1 comment
Open

Windows code is probably still not quite right #4

evilpie opened this issue Aug 2, 2018 · 1 comment

Comments

@evilpie
Copy link
Owner

evilpie commented Aug 2, 2018

If the path length changes (file move?) between the GetFinalPathNameByHandleW calls we are going to be in trouble. I feel like I should just copy the fill_utf16_buf code in rust.

@evilpie
Copy link
Owner Author

evilpie commented Aug 3, 2018

I think 22bdbbf should be enough to at least make this method safe by adding the len2 >= len check. Now we fail when the path length increases between the two calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant