Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Req Support for Llama 3.1 #21

Open
jkfnc opened this issue Jul 23, 2024 · 3 comments
Open

Req Support for Llama 3.1 #21

jkfnc opened this issue Jul 23, 2024 · 3 comments

Comments

@jkfnc
Copy link

jkfnc commented Jul 23, 2024

Llama 3.1 got released, anything needs to change to get it working.
@evilsocket
Copy link
Owner

is this a question, a statement or what... ?

@jkfnc
Copy link
Author

jkfnc commented Jul 24, 2024

Sorry, its a question, since LLama 3.1 needs RoPE scaling is there any changes needed to Cake for it to work .

@evilsocket
Copy link
Owner

RoPE is implemented here

cake/cake-core/src/models/llama3/attention.rs

Line 25 in 8a782b8

fn apply_rotary_emb(
... to be honest i didn't have time yet to check the structural differences with LLama 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evilsocket @jkfnc