Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export the missing llhttp APIs via llhttp-ffi bindings (and ensure they're always updated) #128

Open
1 task
rdw-software opened this issue Nov 27, 2022 · 0 comments

Comments

@rdw-software
Copy link
Member

rdw-software commented Nov 27, 2022

Goals:

  • The CI should fail if some function exported by the llhttp library wasn't bound

Quick prototype that I whipped up (Unix only): https://gist.github.com/Duckwhale/a66063ff1bd2d45fbdf4d3de9809065e

export-symbols.sh:

LLHTTP_LIB="libllhttp.so"

echo "Exporting symbols from $LLHTTP_LIB ..."
readelf -Ws $LLHTTP_LIB | awk '{print $8}' | grep llhttp_[^_] > llhttp_symbols.txt

Something like that could export the list of symbols and then a separate step in the OSX/Unix workflow can just run this test. Like the SIGPIPE one it could simply be skipped on Windows, although the tools might also be available in MSYS2?

The most important thing is that this can serve as a reminder, since manually checking for updated APIs is way too troublesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant