New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation warnings in the lua-compat submodule #146

Open

rdw-software opened this issue Dec 11, 2022 · 0 comments

Labels

Complexity: TBD Priority: Normal Scope: Dependencies Status: Accepted Type: Task

Milestone

Member

rdw-software commented Dec 11, 2022

This is actually inside luv and may only happen on Windows (?). Anyway, here's the warning:

[2/52] Compiling Runtime/luvi_compat.c ...
In file included from Runtime/luvi_compat.c:11:
deps/luv/deps/lua-compat-5.3/lprefix.h: In function 'compat53_utf8_escape':
deps/luv/deps/lua-compat-5.3/lprefix.h:69:16: warning: comparison of integer expressions of different signedness: 'long int' and 'unsigned int' [-Wsign-compare]
   69 |     } while (x > mfb);
      |                ^

The text was updated successfully, but these errors were encountered:

rdw-software added Complexity: TBD Type: Task Status: Accepted Priority: Normal Scope: Dependencies labels

rdw-software added this to the Technical Debt milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment