Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favorite icon to detail view #6

Closed

Conversation

ewa1989
Copy link
Owner

@ewa1989 ewa1989 commented Mar 20, 2024

Add check favorite session feature as below.

In ScheduleDetailView, show a star icon on the right side of session title that can tap, and sync favorite state with ScheduleView.

Ref: tryswift#40

Note

  • add star icon on trailing of toolbar
  • sync favorite state with ScheduleView using delegate
  • change ScheduleDetailView.State properties to have session and isFavorited, for indicating sync target session to delegate

ewa1989 added 5 commits March 31, 2024 23:52
…tail-view

# Conflicts:
#	MyLibrary/Sources/ScheduleFeature/Detail.swift
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
#	MyLibrary/Sources/SharedModels/Conference+Extension.swift
#	MyLibrary/Tests/ScheduleFeatureTests/ScheduleTests.swift
…tail-view

# Conflicts:
#	MyLibrary/Tests/ScheduleFeatureTests/ScheduleTests.swift
…tail-view

# Conflicts:
#	MyLibrary/Sources/ScheduleFeature/Schedule.swift
@ewa1989 ewa1989 closed this Apr 1, 2024
@ewa1989 ewa1989 deleted the add-favorite-icon-to-detail-view branch April 1, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant