Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some translations are not working properly #148

Open
fgnm opened this issue Sep 28, 2023 · 0 comments
Open

Some translations are not working properly #148

fgnm opened this issue Sep 28, 2023 · 0 comments

Comments

@fgnm
Copy link
Contributor

fgnm commented Sep 28, 2023

Hi Ethan,
I don't know if this is a numishare issue or something I forget to do, but some translations are not working properly in the coins page. For example

<physDesc>
            <axis>11</axis>
            <measurementsSet>
                <diameter>12</diameter>
                <thickness>13</thickness>
                <weight units="g">14</weight>
            </measurementsSet>
            <conservationState>
                <completeness>intero</completeness>
                <wear xlink:type="simple" xlink:href="http://nomisma.org/id/extremely_worn">Extremely
                    worn</wear>
            </conservationState>
            <countermark>
                <symbol>testo di prova</symbol>
                <description xml:lang="it">descrizione in italiano</description>
                <description xml:lang="en">description in English</description>
            </countermark>
            <testmark>
                <symbol>testo di prova</symbol>
                <description xml:lang="it">descrizione in italiano</description>
               <description xml:lang="en">description in English</description>
            </testmark>
        </physDesc>

With this kind of XML the UI shows a double description field both in Italian and in English (regarding the selected language). I noticed that this happens for many of the fields that should be in theory translatable. Some of them instead works properly, for example the description of the type of a coin side:

<obverse>
                <type>
                    <description xml:lang="it">Working Italian description</description>
                    <description xml:lang="en">Working English description</description>
                </type>
                <symbol>Testo di prova</symbol>
                <persname xlink:type="simple" xlink:role="deity" xlink:href="http://nomisma.org/id/zeus_velchanos">Zeus Velchanos</persname>
                <persname xlink:type="simple" xlink:role="artist" xlink:href="http://nomisma.org/id/k_basileus_cyzicus">K... Basileus</persname>
                <persname xlink:type="simple" xlink:role="engraver" xlink:href="http://nomisma.org/id/p_carisius">P. Carisius</persname>
                <persname xlink:type="simple" xlink:role="portrait" xlink:href="http://nomisma.org/id/c_marius_c_f_tro">C. Marius C F Tro</persname>
            </obverse>

But if I add only a general description without the type tag I still get a double voice in the UI:

<obverse>
                    <description xml:lang="it">Working Italian description</description>
                    <description xml:lang="en">Working English description</description>
                <symbol>Testo di prova</symbol>
                <persname xlink:type="simple" xlink:role="deity" xlink:href="http://nomisma.org/id/zeus_velchanos">Zeus Velchanos</persname>
                <persname xlink:type="simple" xlink:role="artist" xlink:href="http://nomisma.org/id/k_basileus_cyzicus">K... Basileus</persname>
                <persname xlink:type="simple" xlink:role="engraver" xlink:href="http://nomisma.org/id/p_carisius">P. Carisius</persname>
                <persname xlink:type="simple" xlink:role="portrait" xlink:href="http://nomisma.org/id/c_marius_c_f_tro">C. Marius C F Tro</persname>
            </obverse>

I have to manually change XML files in the eXist db because if I add the additional contextual fields, that you recently include, numishare UI doesn't allow me to save the coin properly (I guess because UI still lacks of the new fields).
This is not a big problem, but I thought that there might be issues with indices or something like this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant