Skip to content

Commit e19f1b4

Browse files
authored
Merge pull request #103 from exasol/kaklakariada/issue102
2 parents ef2fffa + 65b93ce commit e19f1b4

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

doc/changelog.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
Unreleased
77
==========
88

9+
🐞 Fixed
10+
--------
11+
* Fix failing vulnerability issue creator when Maven report does not contain "vulnerable" entry
12+
913
🔧 Changed
1014
----------
1115

exasol/toolbox/tools/security.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def gh_security_issues() -> Generator[Tuple[str, str], None, None]:
8787
def from_maven(report: str) -> Iterable[Issue]:
8888
# Note: Consider adding warnings if there is the same cve with multiple coordinates
8989
report = json.loads(report)
90-
dependencies = report["vulnerable"] # type: ignore
90+
dependencies = report.get("vulnerable", {}) # type: ignore
9191
for _, dependency in dependencies.items(): # type: ignore
9292
for v in dependency["vulnerabilities"]: # type: ignore
9393
references = [v["reference"]] + v["externalReferences"]

test/unit/security_test.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,3 +354,8 @@ def test_convert_maven_input(maven_report): # pylint: disable=redefined-outer-n
354354
}
355355
actual = set(security.from_maven(maven_report))
356356
assert actual == expected
357+
358+
359+
def test_convert_maven_input_no_vulnerable(): # pylint: disable=redefined-outer-name
360+
actual = set(security.from_maven("{}"))
361+
assert len(actual) == 0

0 commit comments

Comments
 (0)