Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic outline for security issues tool & action #88

Merged
merged 61 commits into from
Oct 27, 2023
Merged

Add basic outline for security issues tool & action #88

merged 61 commits into from
Oct 27, 2023

Conversation

Nicoretti
Copy link
Member

@Nicoretti Nicoretti commented Oct 23, 2023 •
edited
Loading

✔ Checklist(s)

  • Is the title of the Pull Request correct?
  • Is the title of the corresponding issue correct?
  • Have you updated the changelog?
  • Have you updated the templates?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Are you mentioning the issue which this PullRequest fixes ("Fixes...")

Note: If any of the above is not relevant to your PR just check the box.

🔐 Security

🐞 Bug

✨ Feature

🔧 Refactoring

📚 Documentation

@Nicoretti Nicoretti force-pushed the feature/security-issues-action branch from a7ebdcc to c763552 Compare October 23, 2023 07:28
@Nicoretti Nicoretti force-pushed the feature/security-issues-action branch 2 times, most recently from c25db3a to b3b1e14 Compare October 23, 2023 08:33
@Nicoretti Nicoretti force-pushed the feature/security-issues-action branch from 6c3a9a6 to 565eab7 Compare October 23, 2023 08:40
@Nicoretti Nicoretti force-pushed the feature/security-issues-action branch 9 times, most recently from f891636 to e242ff2 Compare October 23, 2023 12:54
kaklakariada
kaklakariada requested changes Oct 23, 2023
View reviewed changes
exasol/toolbox/tools/security.py Outdated Show resolved Hide resolved
@Nicoretti Nicoretti force-pushed the feature/security-issues-action branch from bc95756 to d369d45 Compare October 24, 2023 11:41
Nicoretti and others added 5 commits October 26, 2023 12:16
kaklakariada
kaklakariada requested changes Oct 26, 2023
View reviewed changes
.github/actions/security-issues/action.yml Outdated Show resolved Hide resolved
.github/actions/security-issues/action.yml Show resolved Hide resolved
doc/github_actions/security_issues.rst Show resolved Hide resolved
doc/github_actions/security_issues.rst Outdated Show resolved Hide resolved
.github/actions/security-issues/action.yml Outdated Show resolved Hide resolved
exasol/toolbox/version.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider marking this as generated in .gitattributes

noxconfig.py Outdated Show resolved Hide resolved
test/integration/cli/security-cve-create.t Outdated
@@ -0,0 +1,23 @@
Crate a GitHub CLI mock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Crate a GitHub CLI mock
Create a GitHub CLI mock

test/integration/cli/security-cve-filter.t Outdated
@@ -0,0 +1,45 @@
Crate a GitHub CLI mock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Crate a GitHub CLI mock
Create a GitHub CLI mock

test/unit/multiversion_test.py Show resolved Hide resolved
Nicoretti and others added 9 commits October 26, 2023 13:26
@Nicoretti @kaklakariada
Update doc/github_actions/security_issues.rst
ece835a 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti @kaklakariada
Update .github/actions/security-issues/action.yml
ad5cb68 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti @kaklakariada
Update .github/actions/security-issues/action.yml
2ca20fa 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti @kaklakariada
Update doc/github_actions/security_issues.rst
b226e45 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti @kaklakariada
Update doc/github_actions/security_issues.rst
1dede7a 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti @kaklakariada
Update exasol/toolbox/tools/security.py
081297e 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti @kaklakariada
Update exasol/toolbox/tools/security.py
33afe8f 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti @kaklakariada
Update exasol/toolbox/tools/security.py
43ae7b2 
Co-authored-by: Christoph Pirkl <[email protected]>
@Nicoretti
Apply code review feedback
58b0fd5
@Nicoretti Nicoretti force-pushed the feature/security-issues-action branch from c2ea94f to 1e74e0c Compare October 27, 2023 08:26
Nicoretti
Nicoretti commented Oct 27, 2023
View reviewed changes
Copy link
Member Author

@Nicoretti Nicoretti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

tkilias
tkilias reviewed Oct 27, 2023
View reviewed changes
test/unit/security_test.py Outdated Show resolved Hide resolved
@Nicoretti Nicoretti requested a review from tkilias October 27, 2023 08:46
@Nicoretti Nicoretti merged commit e265fa2 into main Oct 27, 2023
15 checks passed
@Nicoretti Nicoretti deleted the feature/security-issues-action branch October 27, 2023 08:50
@kaklakariada kaklakariada mentioned this pull request Oct 27, 2023
Closed
@kaklakariada kaklakariada mentioned this pull request Nov 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

@kaklakariada kaklakariada kaklakariada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nicoretti @kaklakariada @tkilias