Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CamelCase test unintentionally removed from acronym exercise #1749

Closed
mattnewport opened this issue Sep 22, 2023 · 2 comments
Closed

CamelCase test unintentionally removed from acronym exercise #1749

mattnewport opened this issue Sep 22, 2023 · 2 comments

Comments

@mattnewport
Copy link

In a recent commit to add test auto-generation, the acronym tests were switched to be auto-generated and in the process the test for CamelCase was lost, seemingly unintentionally:

fn camelcase() {
    assert_eq!(acronym::abbreviate("HyperText Markup Language"), "HTML");
}

Since this is the only test for camel case being handled, the tests now pass without handling this case which simplifies the problem a fair amount. I was made aware of this by a mentee asking why other solutions seemed more complicated than his.

It seems like this was an unintentional change to the test cases for the acronym exercise and that this test should be added back in?

@github-actions
Copy link
Contributor

Hello. Thanks for opening an issue on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this issue has been pre-approved, please link back to this issue on the forum thread and a maintainer or staff member will reopen it.

@mattnewport
Copy link
Author

@senekor This was your commit, I posted in the forums as requested but figured you might be more likely to see it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant