Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eas-cli): execute expo through a package manager to support isolated modules #2151

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Dec 13, 2023

Why

This is a POC for #2150, to test how we can support isolated modules in a good way.

How

  • Removed the existing "resolve expo binary" + "execute expo binary directly".
  • Added execute expo through the used package manager.

TODO

  • Add back the error handling when expo can't be found or executed

Test Plan

See #2150

@byCedric byCedric marked this pull request as draft December 13, 2023 12:49
Copy link

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

Size Change: +441 B (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB +441 B (0%)

compressed-size-action

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (f0012f5) 54.20% compared to head (9272283) 54.22%.

Files Patch % Lines
packages/eas-cli/src/utils/expoCli.ts 30.77% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2151      +/-   ##
==========================================
+ Coverage   54.20%   54.22%   +0.02%     
==========================================
  Files         509      509              
  Lines       18657    18653       -4     
  Branches     3736     3735       -1     
==========================================
  Hits        10112    10112              
+ Misses       8524     8520       -4     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look reasonable and seem like a good direction 👍. I know that this is a draft but I think we can iterate on it and merge it soon.

Thank you for reporting this issue and working on it 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants