Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AppVeyor Configuration and Integrate Windows Testing in GitHub Actions #193

Open
Phillip9587 opened this issue Feb 6, 2025 · 3 comments · May be fixed by #192
Open

Remove AppVeyor Configuration and Integrate Windows Testing in GitHub Actions #193

Phillip9587 opened this issue Feb 6, 2025 · 3 comments · May be fixed by #192
Labels

Comments

@Phillip9587
Copy link

The repository currently includes an AppVeyor configuration file (appveyor.yml), which appears to be used for testing on Windows. However, GitHub Actions is already in use for CI/CD, and Windows-based testing can be integrated into the existing GitHub Actions workflow. Is AppVeyor providing any unique value that GitHub Actions does not?

Proposed Changes

  • Integrate Windows testing into the GitHub Actions workflow.
  • Remove the appveyor.yml configuration if it's no longer needed.
  • Update the README to remove the AppVeyor status badge.
@bjohansebas
Copy link
Member

Yep, we should remove AppVeyor and run the tests on Windows. That's something being done in the other repositories that still have AppVeyor

@ctcpip
Copy link
Member

ctcpip commented Feb 13, 2025

@jonchurch 👀

@jonchurch
Copy link
Member

jonchurch commented Feb 13, 2025

We can remove appveyor, I dont think our appveyor integration is functional anymore

We've removed it in express main repo, as an example. You can see there how we setup windows testing in the matrix.

@Phillip9587 Phillip9587 linked a pull request Feb 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants