Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pytx][mlh] Move ISignalTypeConfigStore from HMA to python-threatexchange #1689

Closed
Dcallies opened this issue Nov 8, 2024 · 4 comments
Closed

[pytx][mlh] Move ISignalTypeConfigStore from HMA to python-threatexchange #1689

Dcallies opened this issue Nov 8, 2024 · 4 comments
Labels
mlh Related to Major League Hacking Fellowship

Comments

@Dcallies
Copy link
Contributor

Dcallies commented Nov 8, 2024

See #1687 for context

https://github.com/facebook/ThreatExchange/blob/main/hasher-matcher-actioner/src/OpenMediaMatch/storage/interface.py#L63-L124

This should be 3 PRs:

  1. Copy IContentTypeConfigStore to a new location in python-threatexchange/threatexchange/storage/interfaces.py
  2. Bump the minor version of python-threatexchange
  3. Remove IContentTypeConfigStore from HMA

There will be followup work after this, will create as a new issue.
@Dcallies Dcallies added the mlh Related to Major League Hacking Fellowship label Nov 8, 2024
@Mackay-Fisher Mackay-Fisher mentioned this issue Nov 29, 2024
Merged
@haianhng31 haianhng31 mentioned this issue Dec 9, 2024
Merged
This was referenced Dec 16, 2024
Merged
Merged
@b8zhong
Copy link
Contributor

b8zhong commented Jan 31, 2025 •
edited
Loading

Guessing we can close this, right? @Dcallies

Edit: Whoops, didn't see the last part wasn't complete

@b8zhong
Copy link
Contributor

b8zhong commented Feb 4, 2025

@Dcallies could you end up posting the followup work (if it wasn't done yet)? Thanks a lot!

@Dcallies
Copy link
Contributor Author

Dcallies commented Feb 5, 2025

Made #1754 to cover the overall thrust

@Dcallies Dcallies closed this as completed Feb 5, 2025
@b8zhong
Copy link
Contributor

b8zhong commented Feb 5, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mlh Related to Major League Hacking Fellowship
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dcallies @b8zhong