Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hma][good first issue] Tweak Message For Checkpointing Sanity Check Failure #1734

Closed
Dcallies opened this issue Jan 24, 2025 · 1 comment
Closed
Labels
Good First Issue These are simple issues that don't require a lot of in-depth knowledge hma Items related to the hasher-matcher-actioner system

Comments

@Dcallies
Copy link
Contributor

https://github.com/facebook/ThreatExchange/blob/main/hasher-matcher-actioner/src/OpenMediaMatch/storage/postgres/impl.py#L344

If two fetch processes are running at the same time, one of them will hopefully fail this assert to try and avoid rewinding the checkpoint.

The message currently cryptically refers to this as a "race condition", but this actually means there are probably multiple instances of the fetch process.

Let's update the message to be less cryptic, and refer to multiple fetch processes or tasks.

@Dcallies Dcallies added Good First Issue These are simple issues that don't require a lot of in-depth knowledge hma Items related to the hasher-matcher-actioner system labels Jan 24, 2025
@anaypurohit0907
Copy link

hi i would like to work on this issue, please guide me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue These are simple issues that don't require a lot of in-depth knowledge hma Items related to the hasher-matcher-actioner system
Projects
None yet
Development

No branches or pull requests

2 participants